Open
Conversation
Add methods to the API that implement sendFax using an array of InputStreams rather than an array of files.
These are unit tests to test the added sendFax methods that send a fax using input streams
# Conflicts: # src/main/java/net/interfax/rest/client/InterFAX.java # src/main/java/net/interfax/rest/client/impl/DefaultInterFAXClient.java
Document upload and send uploaded document were getting a code 411 because the content length was not being sent. This is because Java began filtering content length because it is considered dangerous to be settable. This fix repairs that problem by sending actal zero byte content which circumvents the issue.
The current code code of the uploadChunk method allowed 200 and 202 as valid response codes. However, the server also sends 204s and the method incorrectly identified this as an error. This commit corrects that.
Allow 204s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains two fixes for document upload